Open
Conversation
Add present? method to String class that returns true if the string is not blank (i.e., !blank?). This matches the behavior of Rails' present? method and provides consistency with blank?. Fixes crystal-lang#16757
| # " a ".present? # => true | ||
| # ``` | ||
| # | ||
| # See also: `Object#blank?`. |
Member
There was a problem hiding this comment.
This method doesn't exist...
| # ``` | ||
| # | ||
| # See also: `Object#blank?`. | ||
| def present? : Bool |
Member
There was a problem hiding this comment.
Should add test coverage on this as well.
Sija
reviewed
Mar 20, 2026
| # " a ".present? # => true | ||
| # ``` | ||
| # | ||
| # See also: `Object#blank?`. |
Contributor
There was a problem hiding this comment.
Suggested change
| # See also: `Object#blank?`. | |
| # See also: `String#blank?`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Crystal's standard library lacks a
present?method for strings, which is a common convenience method in other languages like Ruby on Rails. This requires verbose!blank?checks throughout the codebase.Solution
Added
String#present?method that returns!blank?:This matches the Ruby on Rails API and provides a more readable alternative to
!blank?.Validation
Fixes #16757